Skip to content

fix: restore trailing newline in perf-changelog.yaml (unblocks all changelog sweeps)#1815

Open
arygupt wants to merge 1 commit into
mainfrom
fix/changelog-trailing-newline
Open

fix: restore trailing newline in perf-changelog.yaml (unblocks all changelog sweeps)#1815
arygupt wants to merge 1 commit into
mainfrom
fix/changelog-trailing-newline

Conversation

@arygupt

@arygupt arygupt commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Problem

#1798 merged perf-changelog.yaml without a trailing newline. The no-deletions guard in utils/process_changelog.py then trips on every subsequent changelog PR: appending an entry makes the prior last line gain a newline, which git diff reports as a deleted line → ValueError: Deletions are not allowed.

Evidence: run-only sweep PR #1791 fails setup with exactly this on two runs (27721466065, 27721557297). This blocks all changelog-driven sweeps, not just mine.

Fix

Restore the single trailing newline byte.

⚠️ This PR's own run-sweep check will fail on the same guard (the newline change is itself reported as a deletion). Please admin-merge, or push the newline directly to main.

🤖 Generated with Claude Code


Note

Low Risk
Single-byte EOF fix in a changelog file; no runtime or benchmark behavior changes.

Overview
Restores a trailing newline at the end of perf-changelog.yaml after PR #1798 landed the file without one.

Without that byte, any follow-up changelog PR that appends an entry makes git diff show the previous last line as deleted (newline normalization), which triggers ValueError: Deletions are not allowed in utils/process_changelog.py and blocks changelog-driven sweep CI. No benchmark or config content changes—formatting only.

Reviewed by Cursor Bugbot for commit 19589a3. Bugbot is set up for automated code reviews on this repo. Configure here.

#1798 merged perf-changelog.yaml without a trailing newline. process_changelog's
no-deletions guard then trips on EVERY subsequent changelog PR: appending an entry
makes the previous last line 'gain a newline', which git diff reports as a deleted
line -> 'Deletions are not allowed'. This 1-byte fix restores the newline.

NOTE: this PR's own run-sweep check fails on the same guard (the newline change is
itself reported as a deletion) — please ADMIN-MERGE, or push the newline directly
to main.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@arygupt arygupt requested a review from a team June 17, 2026 21:41
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant