Skip to content

[codex] Recover PR 1767 ingest without rerunning sweep#1816

Merged
cquil11 merged 1 commit into
mainfrom
codex/recover-pr-1767-ingest
Jun 17, 2026
Merged

[codex] Recover PR 1767 ingest without rerunning sweep#1816
cquil11 merged 1 commit into
mainfrom
codex/recover-pr-1767-ingest

Conversation

@cquil11

@cquil11 cquil11 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

What changed

Root cause

The original push-to-main run failed while parsing the malformed changelog entry before reuse or ingest could run. Main already contains the indentation correction from PR #1798.

Safety

  • commit and merge message include [skip-sweep]
  • workflow requires an explicit confirmation input
  • source run, PR commit, workflow path, conclusion, and required artifacts are validated
  • no benchmark matrix or GPU runner is referenced

Validation

  • actionlint passed
  • perf-changelog.yaml parses successfully on current main
  • reusable artifact validator passed: 27 benchmark rows and 4 eval jobs

Note

Medium Risk
One-off ops workflow that reuses production ingest credentials and publishes benchmark data to the database; guarded by confirmation input and strict source-run/artifact checks, but still a manual path to production ingest.

Overview
Adds a CPU-only, manually dispatched GitHub Actions workflow (recover-pr-1767-ingest.yml) so PR #1767 benchmark results can be ingested after the original push-to-main run failed on a malformed perf-changelog.yaml entry.

The workflow requires typing recover-pr-1767, then validates source run-sweep run 27595478969 (PR event, success, head SHA, required non-expired artifacts). It rebuilds merge config by checking out the original merge commit, fixing the config-keys indentation in perf-changelog.yaml, creating a synthetic commit-tree, and running process_changelog.py for full-config.json and changelog metadata (base/head refs aligned to the original merge). It downloads and filters sweep artifacts like the normal reuse path, runs validate_reusable_sweep_artifacts.py, uploads reused-ingest-artifacts and changelog-metadata, and dispatches ingest-results to InferenceX-app—no GPU matrix or sweep rerun.

Reviewed by Cursor Bugbot for commit e851db4. Bugbot is set up for automated code reviews on this repo. Configure here.

@cquil11 cquil11 requested a review from a team June 17, 2026 22:48
@cquil11 cquil11 merged commit add3381 into main Jun 17, 2026
4 checks passed
@cquil11 cquil11 deleted the codex/recover-pr-1767-ingest branch June 17, 2026 22:48

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e851db4. Configure here.


permissions:
actions: read
contents: read

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing actions write permission

High Severity

The workflow caps GITHUB_TOKEN at actions: read and contents: read, then runs actions/upload-artifact for ingest payloads. Upload needs actions: write, so the job likely fails after validation and never supplies artifacts for the downstream ingest dispatch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e851db4. Configure here.

jq -e --arg name "$required" \
'.artifacts[] | select(.name == $name and (.expired | not))' \
<<<"$artifacts_json" >/dev/null
done

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifact list not paginated

Medium Severity

Required source artifacts are checked with a single gh api call limited to per_page=100. Full sweeps can expose more than 100 artifact records, so results_bmk, eval_results_all, or run-stats may be omitted and validation fails despite a valid source run.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e851db4. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant