orchestrator: complete PLUGIN_VERSION self-sync in system_status#13
Closed
evannadeau wants to merge 1 commit into
Closed
orchestrator: complete PLUGIN_VERSION self-sync in system_status#13evannadeau wants to merge 1 commit into
evannadeau wants to merge 1 commit into
Conversation
6 tasks
Author
|
Closing as duplicate. PR #10 (filed 2026-05-15) already includes the identical version-drift fix at Reviewer's verification of the 5 inert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the
PLUGIN_VERSIONself-sync cleanup introduced in commitd9a7bb3(orchestrator 0.30.31). That cleanup added a module-loadPLUGIN_VERSIONconstant read frompackage.jsonprecisely to eliminate version-string drift, with the comment atplugins/orchestrator/mcp/server.ts:32-37documenting the intent. Thesystem_statusline atplugins/orchestrator/mcp/server.ts:655was missed during that consolidation, so every version bump since (0.30.32 → 0.30.38) has shipped with that line reporting the stale literal0.30.28. Operator-visible discrepancy:package.json, manifest, and startup banner all report the current version, butsystem_statusreturns0.30.28.Change
plugins/orchestrator/mcp/server.ts:655— replace literal**0.30.28**with**${PLUGIN_VERSION}**.plugins/orchestrator/dist/server.js— matching rebuild viabun run build. The template literal${PLUGIN_VERSION}is intentional;PLUGIN_VERSIONis a module-load IIFE readingpackage.json, not a build-time constant, so bun preserves the variable reference.Not touched (verified intentional)
Other
0.30.28references inplugins/orchestrator/mcp/server.tsare kept as-is:lookup/notetool descriptions ((0.30.28+)marks when pagination / hard size limit landed). Rewriting these would corrupt API docs.Verification
bun run buildclean, 249 modules bundled.dist/server.jsupdated in sync with source.