Skip to content

orchestrator: complete PLUGIN_VERSION self-sync in system_status#13

Closed
evannadeau wants to merge 1 commit into
SpawnBox-dev:mainfrom
evannadeau:meta-coder/fix-system-status-version-drift
Closed

orchestrator: complete PLUGIN_VERSION self-sync in system_status#13
evannadeau wants to merge 1 commit into
SpawnBox-dev:mainfrom
evannadeau:meta-coder/fix-system-status-version-drift

Conversation

@evannadeau
Copy link
Copy Markdown

Summary

Completes the PLUGIN_VERSION self-sync cleanup introduced in commit d9a7bb3 (orchestrator 0.30.31). That cleanup added a module-load PLUGIN_VERSION constant read from package.json precisely to eliminate version-string drift, with the comment at plugins/orchestrator/mcp/server.ts:32-37 documenting the intent. The system_status line at plugins/orchestrator/mcp/server.ts:655 was missed during that consolidation, so every version bump since (0.30.32 → 0.30.38) has shipped with that line reporting the stale literal 0.30.28. Operator-visible discrepancy: package.json, manifest, and startup banner all report the current version, but system_status returns 0.30.28.

Change

  • plugins/orchestrator/mcp/server.ts:655 — replace literal **0.30.28** with **${PLUGIN_VERSION}**.
  • plugins/orchestrator/dist/server.js — matching rebuild via bun run build. The template literal ${PLUGIN_VERSION} is intentional; PLUGIN_VERSION is a module-load IIFE reading package.json, not a build-time constant, so bun preserves the variable reference.

Not touched (verified intentional)

Other 0.30.28 references in plugins/orchestrator/mcp/server.ts are kept as-is:

  • Lines 175, 209 — commit-history comments describing 0.30.28 behavior (per-PID write-back launcher work).
  • Lines 912, 919, 1298 — user-facing feature-version annotations in lookup / note tool descriptions ((0.30.28+) marks when pagination / hard size limit landed). Rewriting these would corrupt API docs.

Verification

bun run build clean, 249 modules bundled. dist/server.js updated in sync with source.

@evannadeau
Copy link
Copy Markdown
Author

Closing as duplicate. PR #10 (filed 2026-05-15) already includes the identical version-drift fix at mcp/server.ts:655 PLUS a companion path-hashing fix at mcp/server.ts:2181. PR #13 was opened from a stale workspace KB read that didn't reference PR #10 — duplicate caught during a follow-up dispatch. PR #10 has the broader scope and a 24h head-start in the review queue; preserving it.

Reviewer's verification of the 5 inert 0.30.28 references (lines 175, 209, 912, 919, 1298 — all intentional comment-history + feature-version annotations) has been contributed as a comment on PR #10 for the maintainer's context.

@evannadeau evannadeau closed this May 16, 2026
@evannadeau evannadeau deleted the meta-coder/fix-system-status-version-drift branch May 16, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant