chore(ios): GitHub Actions test workflow and complete Vietnamese localization#1175
Open
chore(ios): GitHub Actions test workflow and complete Vietnamese localization#1175
Conversation
…ote f-string syntax error
… surface destinations
…hing the host app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent items bundled because each is small and they touch separate file trees.
CI: iOS test workflow
New
.github/workflows/ios-tests.ymlrunsxcodebuild test -only-testing:TableProMobileTestson:TableProMobile/**,Packages/TableProCore/**,Libs/**, or the workflow file itselfmainmatching the same pathsSetup mirrors the existing
build.yml:macos-26runner, Xcode26.5-beta,scripts/download-libs.sh --forcefor the static libs, then resolve packages and run tests on theiPhone 17 Pro / iOS 26.5simulator. Output is piped throughxcbeautifyfor readable GitHub-Actions logs, andTestResults.xcresultis uploaded as an artifact for 7 days for diagnostics.-skipPackagePluginValidationmatches the local build command in CLAUDE.md.CODE_SIGNING_ALLOWED=NOskips signing on the simulator runner where it isn't needed.Vietnamese localization
TableProMobile/Localizable.xcstringsnow hasvitranslations for all 312 keys (was 246). 66 newly-added Vietnamese translations cover:%@,%lld,%d)Translation choices follow common Vietnamese tech conventions: SQL/dev terms (
SELECT,BLOB,Schema) stay English; everyday UI labels use natural Vietnamese (Kết nối,Truy vấn,Bảng,Khóa chính).JSON serializer uses
separators=(',', ' : ')to match Xcode's xcstrings format (space before colon), so the diff stays focused on actual translation additions instead of whole-file reformatting.Test plan