Skip to content

ci: add pyright workflow#1232

Open
Computerdores wants to merge 14 commits into
TagStudioDev:mainfrom
Computerdores:ci/pyright
Open

ci: add pyright workflow#1232
Computerdores wants to merge 14 commits into
TagStudioDev:mainfrom
Computerdores:ci/pyright

Conversation

@Computerdores
Copy link
Copy Markdown
Collaborator

@Computerdores Computerdores commented Nov 26, 2025

Summary

Adds a pyright workflow using reviewdog (see #1061).

While this is intended to be merged once the code base is ready, in the mean-time I whipped this up to give us an idea were we are in the process of getting there.

PS: I didn't remove the mypy workflow, but it might make sense to put that into this PR as well.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores
Copy link
Copy Markdown
Collaborator Author

Computerdores commented Nov 26, 2025

not quite sure why atm the check passes on the PR (incorrect) but not on the commit (correct), but I suspect that review dog is filtering the errors on the PR because they don't stem from anything modified here, in that case this wouldn't be a problem (and indeed the desired behaviour) in normal use

@Computerdores Computerdores added Type: CI Continuous Integration / workflows Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Nov 26, 2025
@Computerdores
Copy link
Copy Markdown
Collaborator Author

There are now PRs open for all remaining Pyright errors, once those are merged this PR should be mergable, save for any issues that show up in review.

Comment thread pyproject.toml
Comment thread pyproject.toml Outdated
Computerdores and others added 3 commits May 13, 2026 20:59
@Computerdores
Copy link
Copy Markdown
Collaborator Author

All comments are resolved, main is merged in and pyright passes on pull_request and push

@Computerdores Computerdores added Status: Review Needed A review of this is needed and removed Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request labels May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Review Needed A review of this is needed Type: CI Continuous Integration / workflows

Projects

Status: 🏓 Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants