Conversation
CyanVoxel
added
the
Priority: Critical
CyanVoxel
added
TagStudio: Library
Collaborator
Computerdores
left a comment
Computerdores
left a comment
There was a problem hiding this comment.
haven't tested so far but found one major issue
Comment on lines
+891
to
+917
| logger.info("[Library][Migration][201] Dropping type_key from text_fields table...") | ||
| session.execute(text("ALTER TABLE text_fields RENAME TO text_fields_old")) | ||
| session.flush() | ||
| session.execute(create_text_fields_table) | ||
| session.flush() | ||
| session.execute( | ||
| text(""" | ||
| INSERT INTO text_fields (id, name, entry_id, value, is_multiline) | ||
| SELECT id, name, entry_id, value, is_multiline | ||
| FROM text_fields_old | ||
| """) | ||
| ) | ||
| session.execute(text("DROP TABLE text_fields_old")) | ||
|
|
||
| logger.info("[Library][Migration][201] Dropping type_key from datetime_fields table...") | ||
| session.execute(text("ALTER TABLE datetime_fields RENAME TO datetime_fields_old")) | ||
| session.flush() | ||
| session.execute(create_datetime_fields_table) | ||
| session.flush() | ||
| session.execute( | ||
| text(""" | ||
| INSERT INTO datetime_fields (id, name, entry_id, value) | ||
| SELECT id, name, entry_id, value | ||
| FROM datetime_fields_old | ||
| """) | ||
| ) | ||
| session.execute(text("DROP TABLE datetime_fields_old")) |
Collaborator
There was a problem hiding this comment.
According to the sqlite docs this can lead to DB corruption. The docs also describe an alternate way of the same complexity that should work fine though
Member
Author
There was a problem hiding this comment.
Ahh I see, I missed the importance of this before. I've changed it to now use the recommended renaming ordering
Computerdores
moved this from 🏓 Ready for Review
to 👀 In review
in TagStudio Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1367 by dropping the leftover
type_keycolumns from thetext_fieldsanddatetime_fieldstables. Because SQLite does not allow for the removal of columns with foreign key constraints, I've had to create new versions of these tables without the columns and copy the data from the old tables to the new ones, as outlined in the SQLite documentation.I've also made a related change to enforce the ordering of columns inside of both of these tables. SQLAlchemy by default orders these columns strangely as it combines fields from the base
fieldsdefinition, and I did not wish to canonize that ordering in raw SQL statements for the migration.Tasks Completed