Cleanup: Remove dead code and unused files (#1614)

[EntchenEric]

Summary

Closes #1614 — removes dead code and unused files from the project root.

Changes

• Deleted free_tier_guarantee.py, temp_body.txt, temp_fix.py
• Moved DatabaseHealthCheck, OpenAIHealthCheck, TwitchAPIHealthCheck into health/checks/ package directory
• Converted health/checks.py into health/checks/ package (__init__.py)
• Fixed import in OpenAIHealthCheck (was using wrong import path)
• Removed duplicate health check registrations in main.py (OpenAIHealthCheck was registered 3 times, LocaleFileHealthCheck twice)
• Updated import paths in health_check.py and main.py

Checklist

• Delete free_tier_guarantee.py
• Delete temp_body.txt
• Delete temp_fix.py
• Move DatabaseHealthCheck.py
• Move OpenAIHealthCheck.py
• Move TwitchAPIHealthCheck.py

Summary by CodeRabbit

• Bug Fixes

  • Removed background loop health check from startup diagnostics

• Refactor

  • Consolidated health check registration and eliminated duplicate initializations

• Documentation

  • Clarified OpenAI health check validation criteria in module documentation
  • Removed an outdated header comment related to the free tier guarantee

[EntchenEric]

@coderabbitai review

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 44990af1-41c5-4c57-9146-753d3771440c

📥 Commits

Reviewing files that changed from the base of the PR and between 0a27bc7 and 239c1ba.

📒 Files selected for processing (1)

• health/checks/openai.py

---

📝 Walkthrough

Walkthrough

Clarifies the OpenAI health-check docstring to enumerate validations and consolidates startup health-check registration by de-duplicating core checks and assigning explicit polling intervals for external API checks.

Changes

Health check documentation and startup consolidation

Layer / File(s)	Summary
OpenAI health check module documentation health/checks/openai.py	Module docstring rewritten to explicitly list validations: API key configured and API reachable with valid credentials.
Health-check startup registration consolidation main.py	Startup now registers core checks (OpenAI, LocaleFile, Database, TwitchAPI) once and sets explicit intervals for external checks (30m for GIPHY/BrawlStars/ImgBB/Bytebin, 60m for GitHub); duplicate trailing registrations removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• TanjunBot/new_tanjun#1458: Related removal of BackgroundLoopHealthCheck and health-check adjustments.
• TanjunBot/new_tanjun#1500: Introduces external API health checks and interval scheduling that this PR consolidates.
• TanjunBot/new_tanjun#1461: Adds BackgroundLoopHealthCheck and OpenAI health-check wiring, overlapping notifications.

Suggested reviewers

• 2000Arion

Poem

🐰 I hopped through docs with careful paws,
Tidied checks and trimmed duplicate claws.
Intervals set, startup springs true,
Health hums steady — a neat rendezvous.
nibble ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	One change appears out of scope: the docstring update in health/checks/openai.py is unrelated to the primary cleanup objective and does not align with issue #1614 requirements.	Remove the docstring changes to health/checks/openai.py unless they are explicitly required by the linked issue, keeping the PR focused on dead code removal and file organization.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main objective of the PR: removing dead code and unused files from the project root.
Linked Issues check	✅ Passed	All coding-related requirements from issue #1614 have been met: free_tier_guarantee.py, temp_body.txt, and temp_fix.py are removed; health checks are consolidated and moved; imports are corrected; and duplicate registrations are removed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/issue-1614-cleanup-dead-code

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[EntchenEric]

@coderabbitai resolve merge conflict

[coderabbitai]

✅ Merge conflicts resolved successfully!

Resolved 1 conflict file(s). Commit: 239c1ba13b73cb64628ec5c4f30e1b985fb56de5 pushed to fix/issue-1614-cleanup-dead-code.

5 file operation(s)

• health/checks/openai.py (update)
• main.py (update)
• free_tier_guarantee.py (delete)
• temp_body.txt (delete)
• temp_fix.py (delete)

View agent analysis

I'll analyze the merge conflict and resolve it systematically.

The conflict is a delete-modify (DU): `development` (our branch) modified `temp_fix.py` (stage 3), while the incoming branch `fix/issue-1614-cleanup-dead-code` deleted it (stage 1 only, no stage 2). Let me examine both versions.

**Analysis:**

- **Stage 1 (base/ancestor):** `temp_fix.py` with `BackgroundLoopHealthCheck` but no type hints and no imports.
- **Stage 3 (ours/development):** Same class with added type hints (`bot: discord.Bot`) and proper imports — a quality improvement.
- **Incoming branch (fix/issue-1614-cleanup-dead-code):** Deleted `temp_fix.py` entirely as part of dead code cleanup.

**Resolution decision:** The PR's explicit goal is to delete `temp_fix.py` as dead/temporary code (it's literally named `temp_fix.py`). The `development` branch added type hints to it, but the file is still dead code. The PR's intent (and the issue `#1614`) is clear: delete this file. The type-hint addition on `development` is a minor quality tweak to a file that should be deleted — the delete takes precedence.

No unmerged paths remain and `temp_fix.py` no longer appears in git status.

**Resolution summary:**

| | Detail |
|---|---|
| **Conflict type** | Delete-modify (DU): incoming branch deleted the file; `development` added type hints |
| **Incoming branch intent** | Delete `temp_fix.py` as part of PR `#1614` dead code cleanup |
| **Development branch intent** | Add `discord.Bot` type annotations to `BackgroundLoopHealthCheck.__init__` |
| **Resolution** | **Delete the file** — the type-hint addition is a minor quality improvement to a file explicitly targeted for deletion as temporary/dead code. The file name (`temp_fix.py`) itself confirms it was never meant to be permanent. |
| **Behavioral impact** | None — the file was unused dead code. Any consumers of `BackgroundLoopHealthCheck` would need to import from a permanent location, not a `temp_fix.py`. |

[EntchenEric]

@coderabbitai resolve merge conflict

[EntchenEric]

@coderabbitai resolve merge conflict

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@health/checks/openai.py`:
- Around line 3-9: The module docstring contains unresolved Git conflict markers
(<<<<<<<<, ========, >>>>>>>>)—remove those markers and restore a single clear
docstring that keeps the enumerated validation criteria (e.g., "Validates: 1.
openAiKey is configured 2. API is reachable with valid credentials") so the
top-of-file docstring for the openai health check (module docstring in
health/checks/openai.py) is clean and accurate.

🪄 Autofix (Beta)

✅ Autofix completed

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a4345c44-c35e-4ec6-9587-e156c7e164cd

📥 Commits

Reviewing files that changed from the base of the PR and between ece4646 and 52655e8.

📒 Files selected for processing (2)

• health/checks/openai.py
• main.py

[coderabbitai]

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

• health/checks/openai.py

Commit: 0a27bc701749452a3e8d23399561b840ce7b7d7a

The changes have been pushed to the fix/issue-1614-cleanup-dead-code branch.

Time taken: 3m 33s

[EntchenEric]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[EntchenEric]

@coderabbitai resolve merge conflict

[EntchenEric]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.