Skip to content

fix(security): [HIGH] resolve Denial of Service (DoS) vulnerability#162

Open
Tugamer89 wants to merge 1 commit into
mainfrom
fix/security-dos-state-limit-10761521994817724456
Open

fix(security): [HIGH] resolve Denial of Service (DoS) vulnerability#162
Tugamer89 wants to merge 1 commit into
mainfrom
fix/security-dos-state-limit-10761521994817724456

Conversation

@Tugamer89

Copy link
Copy Markdown
Owner

Severity: HIGH

Vulnerability: The application was susceptible to Denial of Service (DoS) and memory exhaustion because there was no upper limit on the number of states that could be added to a finite automaton during its construction.

Impact: A malicious actor or an excessively complex programmatic input could continually add states to the builder, eventually causing an OutOfMemoryError, which would crash the application or service hosting the engine.

Fix: Introduced a MAX_STATES limit of 10,000 in AbstractAutomatonBuilder.java. The addState method now checks if this limit has been reached and throws an IllegalStateException with a descriptive, secure error message before allocating the new state.

Verification: Ran mvn clean test to ensure all existing tests pass. Added a new unit test, testMaxStatesDoSPrevention in AbstractAutomatonBuilderTest.java, which explicitly attempts to add 10,001 states and successfully asserts that the expected IllegalStateException is thrown on the 10,001st addition. Formatted code with mvn spotless:apply.


PR created automatically by Jules for task 10761521994817724456 started by @Tugamer89

Added a hard limit of 10000 states to AbstractAutomatonBuilder to prevent memory exhaustion and DoS attacks caused by unbounded state creation. Introduced a unit test to verify the boundary condition.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant