fix(security): [HIGH] resolve Denial of Service (DoS) vulnerability#162
fix(security): [HIGH] resolve Denial of Service (DoS) vulnerability#162Tugamer89 wants to merge 1 commit into
Conversation
Added a hard limit of 10000 states to AbstractAutomatonBuilder to prevent memory exhaustion and DoS attacks caused by unbounded state creation. Introduced a unit test to verify the boundary condition. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|



Severity: HIGH
Vulnerability: The application was susceptible to Denial of Service (DoS) and memory exhaustion because there was no upper limit on the number of states that could be added to a finite automaton during its construction.
Impact: A malicious actor or an excessively complex programmatic input could continually add states to the builder, eventually causing an OutOfMemoryError, which would crash the application or service hosting the engine.
Fix: Introduced a
MAX_STATESlimit of 10,000 inAbstractAutomatonBuilder.java. TheaddStatemethod now checks if this limit has been reached and throws anIllegalStateExceptionwith a descriptive, secure error message before allocating the new state.Verification: Ran
mvn clean testto ensure all existing tests pass. Added a new unit test,testMaxStatesDoSPreventioninAbstractAutomatonBuilderTest.java, which explicitly attempts to add 10,001 states and successfully asserts that the expectedIllegalStateExceptionis thrown on the 10,001st addition. Formatted code withmvn spotless:apply.PR created automatically by Jules for task 10761521994817724456 started by @Tugamer89