Skip to content

fix(ui): Fix version switcher lock when navigating back (bfcache)#168

Open
Tugamer89 wants to merge 1 commit into
mainfrom
fix-version-switcher-bfcache-3898747374840787430
Open

fix(ui): Fix version switcher lock when navigating back (bfcache)#168
Tugamer89 wants to merge 1 commit into
mainfrom
fix-version-switcher-bfcache-3898747374840787430

Conversation

@Tugamer89

Copy link
Copy Markdown
Owner

What: Added a pageshow event listener in src/main/javadoc/version-switcher.js to detect when the page is restored from the back/forward cache (e.persisted). If it is, the code removes the disabled and aria-busy attributes from the version switcher dropdown, and resets its title attribute.

Why: In Safari and other modern browsers, navigating to a new page via the version switcher dropdown and then clicking the "Back" button caused the page to load from the bfcache. Since the select dropdown was disabled prior to navigation, the page was restored with the dropdown still disabled, permanently locking the user out of selecting a different version.

Before/After: Visually, the disabled state remains the same when initially selecting an option (it greys out to show it is loading). However, upon navigating back, instead of remaining grey and unclickable, the dropdown is now restored to its default interactive state.

Accessibility: Ensures the dropdown becomes accessible again (removes disabled state) and screen reader notifications correctly reset (removes aria-busy flag) when the page is resurrected via the browser's back button.


PR created automatically by Jules for task 3898747374840787430 started by @Tugamer89

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant