fix(security): [HIGH] resolve state explosion DoS vulnerability in automaton builders#171
fix(security): [HIGH] resolve state explosion DoS vulnerability in automaton builders#171Tugamer89 wants to merge 1 commit into
Conversation
… builders Adds a MAX_STATES limit to AbstractAutomatonBuilder to prevent memory exhaustion DoS attacks during regex parsing or manual automaton construction. Includes test cases. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
1 participant
Severity: HIGH
Vulnerability: State explosion / memory exhaustion Denial of Service (DoS) in automaton builders
Impact: A malicious regular expression or programmatically constructed automaton could attempt to create an unbounded number of states, resulting in memory exhaustion (OOM) and causing a denial of service.
Fix: Added a strict limit (
MAX_STATES = 10000) to the state size inAbstractAutomatonBuilder.javaand enforced it inside theaddStatemethod to securely fail with anIllegalStateExceptionbefore memory limit violations occur.Verification: Ran the unit test suite and verified that adding 10001 states triggers the expected
IllegalStateException. Tested via Maven.PR created automatically by Jules for task 13076676372060888691 started by @Tugamer89