Restrict all context.{get,set} in same component to use same elem type#645
Open
lukewagner wants to merge 2 commits intomainfrom
Open
Restrict all context.{get,set} in same component to use same elem type#645lukewagner wants to merge 2 commits intomainfrom
lukewagner wants to merge 2 commits intomainfrom
Conversation
Member
Author
|
Additionally, the second commit tweaks the binary format rules in |
alexcrichton
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation rules that require all
context.getandcontext.setdefinitions inside a component to use the same element type (currently eitheri32or, with #624,i64). Conceptually, this validation rule would be attached to what it means for acomponentdefinition to be valid. In the short-term, this might allowcontext.set i32to avoid a store-zero when implemented on 32-bit CPUs (to clear the high bits of the underlyingi64storage) if there's no whole-component information to indicate the absence ofcontext.set i64s in the same component. In the longer-term, this change would allow core wasm reference types to be efficiently used as element types, since the simple aliasing approach ofi32/i64wouldn't work.(cc @adambratschikaye)