Skip to content

Add prometheus integration with ServiceMonitor CRD#371

Open
peixian wants to merge 2 commits into
WhatsApp:mainfrom
peixian:peixian/add-servicemonitor
Open

Add prometheus integration with ServiceMonitor CRD#371
peixian wants to merge 2 commits into
WhatsApp:mainfrom
peixian:peixian/add-servicemonitor

Conversation

@peixian
Copy link
Copy Markdown
Contributor

@peixian peixian commented Apr 13, 2025

Adds a ServiceMonitor for HAProxy (https://observability.thomasriley.co.uk/prometheus/configuring-prometheus/using-service-monitors/).

Off by default, can be enabled by users as needed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 13, 2025
@peixian peixian force-pushed the peixian/add-servicemonitor branch from 3771ddd to 472ddf7 Compare April 13, 2025 23:36
# Enables service monitor for the prometheus operator.
enableServiceMonitor: false
prometheus:
release: my-prometheus-release
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these be updated in runtime?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the intention is that the user provides their own values.yaml

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Jun 5, 2026

Hi @peixian!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants