ci: GHA workflow security cleanup#483
Open
emptyhammond wants to merge 3 commits into
Open
Conversation
Prevents the default GITHUB_TOKEN from being written into the local git config after checkout, where later steps could read or exfiltrate it. This is a routine hardening step following a workflow security audit.
Add a workflow-level permissions: {} default and grant each job only the
GITHUB_TOKEN scopes it actually needs (contents: read for checkout in both
workflows, plus deployments: write and id-token: write for the build job's
preview upload). Follow-up to a workflow security audit; no functional
change to the steps themselves.
Replace floating major-version tags (e.g. actions/checkout@v4) with the exact commit SHA they currently resolve to, preserving the version as a trailing comment. This is the standard mitigation for the supply-chain risk of upstream tag moves silently changing what runs in CI, and was flagged by a workflow security audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine hygiene pass over the GitHub Actions workflows in this repo, addressing findings from a workflow security audit. Changes are split into three commits, one per finding type:
actions/checkoutsteps so the defaultGITHUB_TOKENis not left in the local git config after checkout.GITHUB_TOKENpermissions explicitly: top-levelpermissions: {}, with each job granted only the scopes it actually needs (contents: readfor both, plusdeployments: write/id-token: writefor the build job's preview upload.No behavioural changes intended — the workflows run the same checks against the same inputs.