Skip to content

Revert "fix: explicitly pass model provider on session resume (#139)"#164

Open
xiatg wants to merge 1 commit into
agentclientprotocol:mainfrom
xiatg:revert-pr-139
Open

Revert "fix: explicitly pass model provider on session resume (#139)"#164
xiatg wants to merge 1 commit into
agentclientprotocol:mainfrom
xiatg:revert-pr-139

Conversation

@xiatg
Copy link
Copy Markdown

@xiatg xiatg commented May 28, 2026

Summary

  • Reverts PR fix: explicitly pass model provider on session resume #139 which introduced getResumeModelProvider() with a hardcoded fallback to "openai"
  • The previous change forced the model provider to default to "openai" when none was explicitly passed, overriding the user's configured provider in ~/.codex/config.toml
  • Per the official configuration guide, users can set their model provider in ~/.codex/config.toml — the hardcoded fallback bypasses this

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant