Skip to content

feat: Add HTTP and Adaptive crawler templates#1888

Draft
vdusek wants to merge 1 commit intomasterfrom
feat/http-and-adaptive-crawler-templates
Draft

feat: Add HTTP and Adaptive crawler templates#1888
vdusek wants to merge 1 commit intomasterfrom
feat/http-and-adaptive-crawler-templates

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented May 9, 2026

Description

Adds the missing crawler types to the cookiecutter project template (crawlee create) and the scheduled E2E templates tests:

  • http — uses HttpCrawler (no HTML parser, raw bytes).
  • adaptive-beautifulsoup — uses AdaptivePlaywrightCrawler.with_beautifulsoup_static_parser().
  • adaptive-parsel — uses AdaptivePlaywrightCrawler.with_parsel_static_parser().

Each has its own main_*.py and routes_*.py template files in the same shape as the existing static-parser templates. Cookiecutter extras resolution and Docker base-image selection were extended; the FROM if-ladder in the Dockerfile was refactored into a single set base_image block, and the http-client extra logic was collapsed into one branch.

The e2e templates test (tests/e2e/project_template/test_static_crawlers_templates.py) and the scheduled-tests matrix (.github/workflows/on_schedule_tests.yaml) were extended with the three new crawler types and matching pytest markers, so they get the same coverage as existing types.

Issues

  • Closes #ISSUE if applicable (none linked).

Notes

  • Adaptive templates install both beautifulsoup and parsel extras regardless of the chosen parser, because AdaptivePlaywrightCrawler imports both bs4 and parsel at module load time. The upstream adaptive-crawler extra in pyproject.toml does not declare these — fixing that is tracked separately.
  • Unifying the lists in cookiecutter.json, tests/e2e/conftest.py, the test parametrize block, and the CI matrix into a single source of truth is tracked in a separate proposal (not part of this PR).

Add `http`, `adaptive-beautifulsoup`, and `adaptive-parsel` to the cookiecutter
project template (`crawlee create`), plus matching markers, parametrization in
the e2e templates tests, and entries in the scheduled-tests CI matrix so the
new types get the same coverage as existing ones.
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels May 9, 2026
@vdusek vdusek self-assigned this May 9, 2026
@github-actions github-actions Bot added this to the 140th sprint - Tooling team milestone May 9, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label May 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.73%. Comparing base (590ad1c) to head (1dcab22).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1888      +/-   ##
==========================================
+ Coverage   92.69%   92.73%   +0.04%     
==========================================
  Files         161      161              
  Lines       11356    11356              
==========================================
+ Hits        10526    10531       +5     
+ Misses        830      825       -5     
Flag Coverage Δ
unit 92.73% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants