feat: add var() resolution and mode-* descriptors#7
Merged
Conversation
- Resolve var(--X) references in initial-value by chasing through the token graph until a literal is found. Handles chains (A→B→C) and circular references (kept as-is). Original unresolved value preserved in RawInitialValue for CSS output. - Add mode-* extended descriptors (e.g., mode-dark, mode-high-contrast) to express color mode overrides directly in @Property blocks. Mode values also get var() resolution with originals in RawModes. - JSON output: initialValue and modes contain resolved literals. - CSS output: :root preserves var() references, mode blocks generated as :root[data-color-mode='<mode>'] selectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
var(--X)references ininitial-valueby chasing through the token graph until a literal is found. Handles chains (A→B→C) and circular references (kept as-is).mode-*extended descriptors (e.g.,mode-dark,mode-high-contrast) to express color mode overrides directly in@propertyblocks. Mode values also getvar()resolution.Authoring
Output
JSON (
cssmark build): resolved literals{ "name": "--color-action-primary", "initialValue": "#2C49EF", "modes": { "dark": "#94B4FF" } }CSS (
cssmark css): preservesvar()references + generates mode blocks