[FIX] Overly long function _register#268
Conversation
Refactored hookwise/auth.py to split the overly long _register function. - Created _register_login_routes and _register_2fa_routes to logically group routes. - Extracted complex logic into private module-level helper functions: _handle_otp_login, _handle_credential_login, and _handle_2fa_setup_post. - Verified functionality with existing tests (tests/test_auth_flow.py and tests/test_app.py). - Ensured compliance with linting and formatting standards using ruff. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
The _register function in hookwise/auth.py was overly long and handled multiple concerns. It has been decomposed into smaller, more focused registration functions and private helpers to improve maintainability and readability. Login and logout routes are now registered via _register_login_routes, while 2FA-related routes are handled by _register_2fa_routes. Complex POST handling logic has been extracted into dedicated private functions.
PR created automatically by Jules for task 6368577609101177626 started by @arumes31