Refactor tooltip style contract#707
Merged
Merged
Conversation
Member
TorinAsakura
requested changes
Jun 10, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a67941938
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ntainer-style-contract # Conflicts: # .pnp.cjs # ui-parts/tooltip/stories/story-tooltip.tsx
TorinAsakura
requested changes
Jun 16, 2026
TorinAsakura
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
Как проверять
Контекст: Storybook
Действие: открыть Tooltip в текущей версии и версии master, сравнить поведение и внешний вид дефолтного варианта
Ожидаемый результат: Tooltip выглядит и ведёт себя так же, как в master; открытие, закрытие, arrow, animated и floating-позиционирование работают без регрессий
Контекст: использование
@atls-ui-parts/tooltipкак библиотечного компонента без кастомногоcontainerДействие: передать пользовательские стили в Tooltip через публичный API компонента для дефолтного container
Ожидаемый результат: Tooltip принимает пользовательские стили без замены container; внутренние классы дефолтного container не перетираются; arrow, animated, open и позиционирование сохраняются; дефолтный Tooltip выглядит и ведёт себя так же, как в master
Пруфы
Details
2026-06-10.03.19.02.mov