ci: skip verifyRelease in prepare-release dry-run and add changelog#134
Open
SamuelSSalazar wants to merge 1 commit into
Open
ci: skip verifyRelease in prepare-release dry-run and add changelog#134SamuelSSalazar wants to merge 1 commit into
SamuelSSalazar wants to merge 1 commit into
Conversation
78d261d to
da7dd19
Compare
4c2901b to
9a13f20
Compare
9a13f20 to
baa5cd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Fixes the
Prepare Releaseworkflow, two bugs introduced by #122The
Detect Next Versionstep ransemantic-release --dry-run --verify-conditions false. That flag only skips theverifyConditionsstep. TheverifyReleasestep still executed the@semantic-release/execplugin'sverifyReleaseCmd, which runsnpm packand thenrl-wrapper. As a result:rl-wrapper: not found: that binary is only installed inrelease.yml, notprepare-release.yml, so the step errored..tgzin the release PR :npm packleftxml-encryption-*.tgzin the workspace, whichcreate-pull-requestthen committed into the release PR (see chore(release): 4.0.1 #130 vs. the clean chore(release): 4.0.0 #124).This PR fixes both issues by adding
--verify-release falseso the dry-run only runsanalyzeCommits(still using theconventionalcommitspreset from.releaserc.json), and never triggersnpm pack/rl-wrapper.This PR also adds a
CHANGELOG.mdgeneration step and hardensDetect Next Versionto fail the step on a non-zerosemantic-releaseexit instead of masking it behind theawkpipe.Testing
Ran the dry-run command locally and verified that:
The next release version is 4.0.1is printed and captured by theawkpipeline..tgzis created.rl-wrapperinvocation.CHANGELOG.mdis updated with a new conventionalcommits-formatted section, preserving prior entries.