Skip to content

feat: add sequencer-only benchmark role#188

Merged
niran merged 2 commits into
mainfrom
niran/sequencer-only-roles
May 27, 2026
Merged

feat: add sequencer-only benchmark role#188
niran merged 2 commits into
mainfrom
niran/sequencer-only-roles

Conversation

@niran
Copy link
Copy Markdown
Contributor

@niran niran commented May 19, 2026

Summary

  • Add benchmark-level roles config while preserving the default sequencer+validator behavior.
  • Support roles: [sequencer] for benchmarks that only need sequencer/block-building or snapshot startup coverage.
  • Normalize config roles into an internal execution mode where the sequencer phase always runs and validator replay is optional.
  • Reject validator-only configs because validator benchmarks consume payloads produced by the sequencer phase.
  • Reject validator-scoped thresholds for sequencer-only benchmarks.
  • Make validator metrics optional in run metadata.
  • Document the sequencer-only snapshot/load-test use case.

Tests

  • go test ./runner/benchmark
  • go test ./runner/...

type=routine
risk=low
impact=sev5

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 19, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@niran niran marked this pull request as draft May 19, 2026 19:03
@niran niran changed the title Add sequencer-only benchmark role feat: add sequencer-only benchmark role May 21, 2026
@niran niran marked this pull request as ready for review May 27, 2026 05:37
@niran niran requested review from meyer9 and wlawt May 27, 2026 05:37
Comment on lines +285 to +286
func (nb *NetworkBenchmark) runsValidator() bool {
return nb.mode.RunValidator
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wonder if we can just call the inner content of this fn instead?

@niran niran merged commit ea33f3b into main May 27, 2026
14 checks passed
@niran niran deleted the niran/sequencer-only-roles branch May 27, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants