fix(ci): bump rules_cc to 0.2.17 to unbreak RBE#3788
Open
kevinpark1217 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the rules_cc dependency from version 0.1.5 to 0.2.17 across multiple configuration files, including MODULE.bazel, internal_dev_deps.bzl, python/private/py_repositories.bzl, and the integration test module. This update is necessary to expose cc/toolchains:feature_injection.bzl for RBE support. I have no further feedback to provide.
RBE on BazelCI has been failing for every recent PR with:
ERROR: error loading package '@@+internal_dev_deps+buildkite_config//cc':
.../cc_toolchain_config.bzl:35:6:
cannot load '@@rules_cc+//cc/toolchains:feature_injection.bzl': no such file
BazelCI's injected `buildkite_config//cc/cc_toolchain_config.bzl`
unconditionally loads `feature_injection.bzl`, which was added in
`rules_cc` 0.2.17 (commit 64024621, 2026-02-11). The previously-pinned
0.1.5 does not have it, so RBE jobs fail at analysis time.
Bump the bzlmod and WORKSPACE/`http_archive` pins everywhere `rules_cc`
is declared: `MODULE.bazel`, `python/private/py_repositories.bzl`,
`internal_dev_deps.bzl`, and `tests/integration/local_toolchains/MODULE.bazel`.
All `@rules_cc//...` load paths used by rules_python are unchanged in
0.2.17.
kevinpark1217
force-pushed
the
fix-ci-bump-rules-cc
branch
from
d13b4f3 to
bafac01
Compare
Contributor
Author
|
@rickeylev @aignas Simple fix for the current CI failures in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RBE has been failing on every recent build (e.g.
mainHEAD build 15455) with:BazelCI's injected
buildkite_config//cc/cc_toolchain_config.bzlnow loadsfeature_injection.bzlunconditionally. That file landed inrules_cc0.2.17; the current pin is 0.1.5. RBE uses bzlmod (see.bazelrc), so the bzlmod pin is what matters.What changed
Bzlmod
rules_ccpin only:0.1.5→0.2.17inMODULE.bazelandtests/integration/local_toolchains/MODULE.bazel.WORKSPACE
http_archivepins are intentionally left at0.1.5. Bumping them broke 22 jobs in the first push to this PR (build 15462) becauserules_cc0.2.17 requires WORKSPACE consumers to also callcompatibility_proxy_repo()— a breaking change for downstream users. WORKSPACE jobs don't use RBE in this repo.Test plan
Reproduced both the original RBE break and the workspace regression in a Docker container, then verified the split-pin fix locally:
bazel build //python/...+examples/multi_python_versions //...passbazel mod graphresolvesrules_cc@0.2.17;cc/toolchains/feature_injection.bzlis presentSurfaced while investigating CI on #3775/#3776 (backports for #3773).