feat: support rechunking using Chunkah#790
Open
HastD wants to merge 1 commit into
Open
Conversation
HastD
force-pushed
the
chunkah
branch
2 times, most recently
from
effed06 to
0e92302
Compare
Add a `--chunkah` option to `bluebuild build` that rechunks the image using [Chunkah](https://github.com/coreos/chunkah), a more modern, content-agnostic rechunker that's actively maintained and should offer various improvements over build-chunked-oci and the legacy rechunker. This is implemented using a fairly generic "post-build hook" mechanism that allows a post-processing step (such as rechunking) to be applied after building the image but before tagging and pushing.
gmpinder
requested changes
Jun 14, 2026
Comment on lines
+16
to
+20
| let mut initial_args = Vec::<OsString>::new(); | ||
| if use_sudo { | ||
| initial_args.push("sudo".into()); | ||
| if blue_build_utils::has_env_var(blue_build_utils::constants::SUDO_ASKPASS) { | ||
| initial_args.push("-A".into()); |
Member
There was a problem hiding this comment.
I think I should work on that cmd_append! macro. This feels more messy than it needs to be.
Member
There was a problem hiding this comment.
Ok, went ahead and made it. It's called cmd_mut!. Released on version 1.5.0.
https://gitlab.com/wunker-bunker/comlexr/-/commit/1523e3e65c7d344c1ec1874b5f6567ce84f134f9
| #[derive(Debug, Clone, Copy, Builder)] | ||
| #[builder(derive(Debug, Clone))] | ||
| pub struct RemoveImageOpts<'scope> { | ||
| pub image: &'scope str, |
Member
There was a problem hiding this comment.
Could we try to keep this as &Reference? I'm noticing extra .to_string() calls being added which means more allocations. Also it helps to keep the API stricter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
--chunkahoption tobluebuild buildthat rechunks the image using Chunkah, a more modern, content-agnostic rechunker that's actively maintained and should offer various improvements over build-chunked-oci and the legacy rechunker.This is implemented using a fairly generic "post-build hook" mechanism that allows a post-processing step (such as rechunking) to be applied after building the image but before tagging and pushing.