Bound package download timeout across headers and streaming#11
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment 3470144242
Bound package download timeout across headers and streaming
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review identified that the intended 10-minute download timeout only covered response headers, while body streaming could stall indefinitely. This update applies a single timeout budget to the full download lifecycle.
Timeout semantics
HttpClient.TimeouttoTimeout.InfiniteTimeSpanto avoid split timeout behavior when using streaming.CancellationTokenSourceand used it as the single timeout mechanism.Download path update (
Program.cs)GetAsync(url, HttpCompletionOption.ResponseHeadersRead, token)so header fetch is cancellable by the same token.CopyToAsyncandFlushAsyncso stalled stream copy is also bounded.