Fix negative period delta calculation in sync-leaderboard#249
Open
Abhinav21Chauhan wants to merge 1 commit into
Open
Fix negative period delta calculation in sync-leaderboard#249Abhinav21Chauhan wants to merge 1 commit into
Abhinav21Chauhan wants to merge 1 commit into
Conversation
Contributor
|
Thank you for submitting a pull request. Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully. Formatting and Branching
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked Issue
Fixes # (issue number)
#238 fixed
Changes Made
Summary
This PR prevents negative period deltas in
processTimeframe()by clampingeasySolved,mediumSolved, andhardSolvedto a minimum of0usingMath.max(0, ...).Changes
easySolveddelta to zero.mediumSolveddelta to zero.hardSolveddelta to zero.This prevents negative solved counts and negative leaderboard scores when the
current cumulative totals are lower than the previous snapshot.
Type of Change
Testing
Checklist
npx prettier --write .before submittingfeature/*branch, not themainbranchScreenshots / Screen Recording