Skip to content

fix: pass reaction-token to slash-command-dispatch and clean up workf…#255

Merged
jagdish-15 merged 1 commit into
codepvg:mainfrom
Tamcodes4:fix/slash-command-reaction-token
Jun 27, 2026
Merged

fix: pass reaction-token to slash-command-dispatch and clean up workf…#255
jagdish-15 merged 1 commit into
codepvg:mainfrom
Tamcodes4:fix/slash-command-reaction-token

Conversation

@Tamcodes4

Copy link
Copy Markdown
Contributor

Description

Follow-up to #250, addressing feedback on #236.

  • Adds reaction-token: ${{ secrets.PAT }} to slash-command-dispatch.yml. The action's own job log on the test PR shows explicit Failed to set reaction on comment annotations under the current workflow, passing a token with write-scoped credentials for reactions resolves that documented failure mode, using the same PAT already configured for dispatching.
  • Removes the explanatory comments from both workflow files per request, since they're not needed in production.
  • Updates the post-format completion message in format-command.yml, it previously said "Note for Contributors," but since /format is now restricted to maintainers/collaborators, that audience framing was outdated.

Linked Issue

Relates to #236

Changes Made

  • slash-command-dispatch.yml: added reaction-token input; removed explanatory comment block.
  • format-command.yml: removed explanatory comment block; reworded the bot's push-completion comment to drop "for Contributors," since the audience triggering /format is now maintainers/collaborators only.

Type of Change

  • Bug fix
  • New feature
  • UI/Visual update
  • Documentation update
  • Refactor

Testing

  • Tested locally
  • Tested on mobile viewport (if applicable)
  • No console errors introduced

Validated both workflow files with actionlint (no errors) and prettier --check.

Checklist

  • My code follows the project's coding style
  • I have formatted my code locally by running npx prettier --write . before submitting
  • I am submitting my PR from a dedicated feature/* branch, not the main branch
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have updated documentation if required
  • I have linked the relevant issue

Screenshots / Screen Recording

N/A , CI/workflow-only change with no UI impact.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request.

Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully.

Formatting and Branching

  • Please confirm you have formatted your code locally using npx prettier --write ., or you can simply comment /format on this PR to have our bot do it for you!
  • Ensure this PR is made from a feature/* branch and not main.

Note: This project is currently maintained by a solo maintainer, so reviews and responses may sometimes take a little time. Thanks for your patience.

@jagdish-15 jagdish-15 added type:bug Something isn't working level:beginner Indicates the difficulty gssoc:approved labels Jun 27, 2026
@jagdish-15 jagdish-15 merged commit 8d803b3 into codepvg:main Jun 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved level:beginner Indicates the difficulty type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants