Read dd-originated flag and update test#45
Open
chante-gobel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's being changed
ddOriginatedto the return value ofhandlePushinfoundation.ts- it now resolves[{ url, ddOriginated }]whereddOriginatedreflects the dd-originated flag from the push payloadhandlePush- it was incorrectly labelledfoundation.spec.tsto correctly test the new return shape and call the right method namehandlePushnothandleLinkWhy it's being changed
Dotdigital push notifications include a
dd_originatedflag in the payload to indicate the message was sent by the Dotdigital platform. Consumers of the SDK need access to this flag to differentiate Dotdigital-originated pushes from other push messages.How to review / test this change
Link to work item
https://dev.azure.com/dotdigital/ec/_workitems/edit/345331