feat: add search_indexes parameter to ProcessChunks and ProcessFileEmbedding (#856)#1171
Open
pyramation wants to merge 1 commit into
Open
feat: add search_indexes parameter to ProcessChunks and ProcessFileEmbedding (#856)#1171pyramation wants to merge 1 commit into
pyramation wants to merge 1 commit into
Conversation
…bedding (#856) Adds search_indexes to ProcessChunks parameter_schema and ProcessFileEmbedding's chunks sub-config with default ['fulltext']. Enables hybrid RAG by opting into fulltext (tsvector), bm25, or trigram search on the chunks content column. Companion to constructive-io/constructive-db#1164
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
search_indexesparameter to theProcessChunksnode type definition and theProcessFileEmbeddingchunks sub-config in the node type registry.This enables hybrid RAG workflows — keyword search (tsvector/BM25/trigram) alongside vector similarity search on the chunks table's content column.
The default
[\"fulltext\"]is centralized here in theparameter_schemaand applied bytable_modulenormalization before reaching the SQL generator.Review & Testing Checklist for Human
search_indexesproperty matches the SQL column type (jsonb array of strings)['fulltext']aligns with the SQL column default'[\"fulltext\"]'::jsonbNotes
Link to Devin session: https://app.devin.ai/sessions/2b5a29d83d3f478e8d3d972653b4879c
Requested by: @pyramation