[6.x] Replace custom user photo picker with Asset field#18771
Open
[6.x] Replace custom user photo picker with Asset field#18771
Conversation
riasvdv
force-pushed
the
feature/profile-photo-asset-picker
branch
from
27b4de9 to
7ab27dd
Compare
Member
|
We intentionally didn’t make these normal asset select inputs, because you wouldn’t want to give users the ability to choose from all other users’ avatars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One small behavioral change: Removing the asset from the user no longer deletes it but keeps the asset as that is consistent with how the asset field operates everywhere else.