feat(visualizations): save image on save#1111
Open
nicolaskempf57 wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
Switched to draft because we want #1088 merged first |
nicolaskempf57
force-pushed
the
feat/add-image-to-charts
branch
from
c56d166 to
fa95aaf
Compare
ThibaudDauce
left a comment
ThibaudDauce
left a comment
Contributor
There was a problem hiding this comment.
Not sure about doing the image capture on @finished. It could lead to race condition since it's raised by echart multiple times on every change in the options? Why not do the generation once on save?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes datagouv/data.gouv.fr#2020
Requires opendatateam/udata#3809
TODO : change CI branch back to main