Skip XML comments and empty sequences in TrainingData iteration#56
Open
c-tonneslan wants to merge 1 commit into
Open
Skip XML comments and empty sequences in TrainingData iteration#56c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
The XML parser used to feed comments and empty <TokenSequence/> nodes straight into trainModel, which then crashed when it tried to iterate over the tokens. Skip both during __iter__ so callers can keep using comments for grouping examples (and unintentional empty sequences don't take the whole training run down with them). Closes datamade#54. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrainingData.__iter__used to hand XML comment nodes and empty<TokenSequence/>elements straight to trainModel, which then crashed when it tried to iterate over the (non-existent) tokens. Skip both during iteration.Concretely:
The fix matches the snippet the issue author suggested. Added two unit tests in
tests/test_xml.py(one for each skip case).Closes #54.