Skip to content

arch: Enhance visible devices handling to permit UUIDs#2930

Open
EdCaunt wants to merge 1 commit into
mainfrom
visible-devices
Open

arch: Enhance visible devices handling to permit UUIDs#2930
EdCaunt wants to merge 1 commit into
mainfrom
visible-devices

Conversation

@EdCaunt
Copy link
Copy Markdown
Contributor

@EdCaunt EdCaunt commented May 13, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 79.66102% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.36%. Comparing base (91d8596) to head (27653c1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
devito/arch/archinfo.py 71.42% 6 Missing and 2 partials ⚠️
tests/test_gpu_common.py 87.09% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2930   +/-   ##
=======================================
  Coverage   83.35%   83.36%           
=======================================
  Files         248      248           
  Lines       51734    51788   +54     
  Branches     4463     4469    +6     
=======================================
+ Hits        43122    43171   +49     
- Misses       7859     7861    +2     
- Partials      753      756    +3     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.66% <44.06%> (-0.05%) ⬇️
pytest-gpu-gcc- 77.96% <5.08%> (-0.08%) ⬇️
pytest-gpu-icx- 77.89% <5.08%> (-0.08%) ⬇️
pytest-gpu-nvc-nvidiaX 69.25% <76.27%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread devito/arch/archinfo.py
return None


def _resolve_uuids_to_indices(uuids):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be changed to return the uuid_to_index mapper -- so to be renamed and also memoized. Then, at the current call site, we apply the uuids...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants