arch: Enhance visible devices handling to permit UUIDs#2930
Open
EdCaunt wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2930 +/- ##
=======================================
Coverage 83.35% 83.36%
=======================================
Files 248 248
Lines 51734 51788 +54
Branches 4463 4469 +6
=======================================
+ Hits 43122 43171 +49
- Misses 7859 7861 +2
- Partials 753 756 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return None | ||
|
|
||
|
|
||
| def _resolve_uuids_to_indices(uuids): |
Contributor
There was a problem hiding this comment.
I think this should be changed to return the uuid_to_index mapper -- so to be renamed and also memoized. Then, at the current call site, we apply the uuids...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.