Removed dependency of setup.cfg from project#2211
Open
p-r-a-v-i-n wants to merge 4 commits intodjango:mainfrom
Open
Removed dependency of setup.cfg from project#2211p-r-a-v-i-n wants to merge 4 commits intodjango:mainfrom
setup.cfg from project#2211p-r-a-v-i-n wants to merge 4 commits intodjango:mainfrom
Conversation
Contributor
Author
Contributor
|
P-r-a-v-i-n is right. I noticed the almost empty pyproject.toml, it doesn't add any value, only noise. I am even sure last packaging PEP mandates the use of setuptools in the absence of a pyproject.toml file. |
Member
carltongibson
left a comment
carltongibson
left a comment
There was a problem hiding this comment.
@p-r-a-v-i-n Happy to take this if you could rebase it after #2220
Thanks for the effort! 🏅
p-r-a-v-i-n
force-pushed
the
remove-setupcfg
branch
from
1bafb0e to
42b8b6f
Compare
p-r-a-v-i-n
commented
Apr 22, 2026
p-r-a-v-i-n
commented
Apr 22, 2026
| deps = | ||
| black | ||
| flake8 | ||
| flake8-pyproject |
Contributor
Author
There was a problem hiding this comment.
This is for loading config for flak8 from pyproject.toml
p-r-a-v-i-n
commented
Apr 23, 2026
| To fix this use ``noglob``:: | ||
|
|
||
| noglob python -m pip install -e .[tests] | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I removed this note because the note was specific to .[tests], and we will not use that syntax for tests.
For extras like daphne, we use now '.[daphne]' which also avoids the zsh issue
p-r-a-v-i-n
force-pushed
the
remove-setupcfg
branch
from
cddd95b to
3258386
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think now it is safe to remove 'setup.cfg'
i have produced the build and wheel on main and on current branch ,and I don't see differences (potentials )