[tools] Don't inline calls to Class.GetHandle for BrowserEngineKit/BrowserEngineCore classes.#25629
Conversation
…owserEngineCore classes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Updates the .NET linker optimization step that inlines ObjCRuntime.Class.GetHandle calls so that it does not inline calls for types in the BrowserEngineKit / BrowserEngineCore namespaces. This aligns the linker’s behavior with the build’s opt-in linking policy for those frameworks, avoiding native link failures (and unintended linking implications) when the frameworks aren’t meant to be linked.
Changes:
- Add a namespace-based skip to prevent inlining
Class.GetHandleforBrowserEngineKit/BrowserEngineCoretypes. - Document the rationale in-code (with an opportunity to improve traceability via a reference link).
- (Suggested) Add regression coverage to prevent this special-casing from being accidentally removed.
✅ [PR Build #9a42135] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #9a42135] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #9a42135] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #9a42135] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 192 tests passed. Failures❌ monotouch tests (macOS) [attempt 8]1 tests failed, 22 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
|
The test failure is unrelated. |
No description provided.