Skip to content

[tools] Don't inline calls to Class.GetHandle for BrowserEngineKit/BrowserEngineCore classes.#25629

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/classgethandle-browserengine
Jun 4, 2026
Merged

[tools] Don't inline calls to Class.GetHandle for BrowserEngineKit/BrowserEngineCore classes.#25629
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/classgethandle-browserengine

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings June 3, 2026 10:29
@rolfbjarne rolfbjarne enabled auto-merge (squash) June 3, 2026 10:29
@rolfbjarne
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the .NET linker optimization step that inlines ObjCRuntime.Class.GetHandle calls so that it does not inline calls for types in the BrowserEngineKit / BrowserEngineCore namespaces. This aligns the linker’s behavior with the build’s opt-in linking policy for those frameworks, avoiding native link failures (and unintended linking implications) when the frameworks aren’t meant to be linked.

Changes:

  • Add a namespace-based skip to prevent inlining Class.GetHandle for BrowserEngineKit / BrowserEngineCore types.
  • Document the rationale in-code (with an opportunity to improve traceability via a reference link).
  • (Suggested) Add regression coverage to prevent this special-casing from being accidentally removed.

Comment thread tools/dotnet-linker/Steps/InlineClassGetHandleStep.cs
Comment thread tools/dotnet-linker/Steps/InlineClassGetHandleStep.cs
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #9a42135] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 9a42135dc2b36ef94781df6528faf5aba9aaed9d [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #9a42135] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 9a42135dc2b36ef94781df6528faf5aba9aaed9d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 9a42135dc2b36ef94781df6528faf5aba9aaed9d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #9a42135] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 9a42135dc2b36ef94781df6528faf5aba9aaed9d [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🔥 [CI Build #9a42135] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 192 tests passed.

Failures

❌ monotouch tests (macOS) [attempt 8]

1 tests failed, 22 tests passed.

Failed tests

  • monotouch-test/macOS/Debug (managed static registrar): TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 23 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 9a42135dc2b36ef94781df6528faf5aba9aaed9d [PR build]

@rolfbjarne
Copy link
Copy Markdown
Member Author

The test failure is unrelated.

@rolfbjarne rolfbjarne merged commit 2743052 into main Jun 4, 2026
54 of 56 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/classgethandle-browserengine branch June 4, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants