Clean up graph.hpp and graph.cpp#564
Merged
arcondello merged 5 commits intoJun 18, 2026
Merged
Conversation
wbernoudy
reviewed
Jun 18, 2026
wbernoudy
reviewed
Jun 18, 2026
| void Graph::topological_sort() { | ||
| if (topologically_sorted_) return; | ||
|
|
||
| // The decisions already have their topological index assigned |
Member
There was a problem hiding this comment.
I think this got moved from two lines up?
Member
Author
There was a problem hiding this comment.
that's how it is in the original
I am inclined to say it's weird but out of scope for this PR.
Co-authored-by: William Bernoudy <william@bernoudy.xyz>
wbernoudy
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly non-functional changes: alphabetization, trailing underscores, logical operators, etc. The one real change is renaming the protected
Graphmethods.I did let two other unrelated formatting changes sneak in 😳
See also #398, #399, #562
AI Generation Disclosure
No AI used.