Skip to content

refactor(vue): remove tanstack query engine, atom is the only backend#813

Open
patroza wants to merge 2 commits into
mainfrom
chore/remove-tanstack-query
Open

refactor(vue): remove tanstack query engine, atom is the only backend#813
patroza wants to merge 2 commits into
mainfrom
chore/remove-tanstack-query

Conversation

@patroza

@patroza patroza commented Jun 27, 2026

Copy link
Copy Markdown
Member

Summary

Removes the TanStack query engine entirely, leaving the Effect Atom engine as the sole query backend. The Atom engine already provided every feature the tanstack path did (cache identity, SWR + focus revalidation, gcTime, retry, structural sharing, hierarchical invalidation, read-dependency derivation).

Changes

  • Drop @tanstack/vue-query / @tanstack/query-core dependencies and patches/@tanstack__query-core.patch.
  • Delete packages/vue/src/internal/tanstackQuery.ts (makeTanstackQuery, makeTanstackQueryClient, makeTanstackQueryInvalidator, makeTanstackQueryCacheUpdater).
  • makeClient no longer accepts legacyQueryEngine and no longer returns tanstackQueryClient; the MakeClientOptions interface is removed.
  • QueryImpl no longer takes a legacyUseQuery override — .query() / .suspense() now always run on the Atom engine alongside .atom() / .family() / .queryNew() / .suspenseNew().

Tests

  • vue/test/query-span.test.ts — dropped the tanstack span test (atom test retained).
  • vue/test/suspense-regression.test.ts — both tests were tanstack-only; converted the structural-sharing test to the atom path (via withQueryOptions), dropped the tanstack key-race regression.
  • vue/test/dependencyInvalidation.test.ts — dropped the tanstack recording/eviction/matrix tests; atom tests and the atom invalidation matrix retained.
  • e2e/test/repoInvalidation.e2e.test.ts — dropped the tanstack engine e2e; atom engine e2e retained.
  • vue/test/makeClient.test.ts — the combineQueryInvalidators test is left as-is (it tests the combiner with two fake invalidators, not the tanstack engine).

Validation

  • pnpm check
  • pnpm lint-fix
  • pnpm --filter @effect-app/vue test run ✅ (83 passed, 2 skipped)
  • pnpm --filter @effect-app/e2e test run

Breaking change

makeClient no longer accepts MakeClientOptions / legacyQueryEngine; callers that passed { legacyQueryEngine: "tanstack" } must drop the argument. The Atom engine is the sole backend.

Changeset

  • @effect-app/vue: minor
  • @effect-app/e2e: patch

- Drop @tanstack/vue-query deps and patches/@tanstack__query-core.patch
- Delete packages/vue/src/internal/tanstackQuery.ts
- makeClient drops legacyQueryEngine option and tanstackQueryClient return
- QueryImpl no longer takes legacyUseQuery override
- Convert tanstack-only tests to the atom path

BREAKING CHANGE: makeClient no longer accepts MakeClientOptions / legacyQueryEngine;
the Atom engine is the sole query backend.
@pkg-pr-new

pkg-pr-new Bot commented Jun 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

@effect-app/cli

npm i https://pkg.pr.new/effect-app/libs/@effect-app/cli@813

effect-app

npm i https://pkg.pr.new/effect-app/libs/effect-app@813

@effect-app/eslint-codegen-model

npm i https://pkg.pr.new/effect-app/libs/@effect-app/eslint-codegen-model@813

@effect-app/eslint-shared-config

npm i https://pkg.pr.new/effect-app/libs/@effect-app/eslint-shared-config@813

@effect-app/infra

npm i https://pkg.pr.new/effect-app/libs/@effect-app/infra@813

@effect-app/vue

npm i https://pkg.pr.new/effect-app/libs/@effect-app/vue@813

@effect-app/vue-components

npm i https://pkg.pr.new/effect-app/libs/@effect-app/vue-components@813

commit: f6f1efd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant