Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
|
2 tasks
Member
Author
|
Blocked by #21275 |
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Consolidate Elastic Cloud target handling for benchmark and smoke test Terraform/workflow paths, while keeping integration server test target passthrough semantics unchanged.
This update:
ec_targetvaluesqa|proec_deploymentTerraform module and passesec_targetthrough from benchmarkEC_TARGETwith target-to-API-base mapping intesting/smoke/lib.shbenchmarksandsmoke-tests-os) withqaChecklist
For functional changes, consider:
How to test these changes
terraform fmt -recursiveEC_TARGETintesting/smoke/lib.sh:qa -> https://public-api.qa.cld.elstc.copro -> https://api.elastic-cloud.com/api/v1/...testing/benchmark/main.tfpassesec_targettomodule "ec_deployment"ecendpoint map still uses API hosts (api_endpoints)testing/infra/terraform/modules/ec_deployment/outputs.tfmaps:qa -> https://admin.qa.cld.elstc.copro -> https://admin.found.noRelated issues
Fixes #21268
Supersedes #21269
Follow up to #21222