-
-
Notifications
You must be signed in to change notification settings - Fork 767
Add Modular Arithmetic approach to RaindropConverter #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
habere-et-dispertire
wants to merge
10
commits into
exercism:main
Choose a base branch
from
habere-et-dispertire:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−0
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
80ccb92
Add Modular Arithmetic approach to RaindropConverter
habere-et-dispertire c5802d2
Refactor RaindropConverter default case
habere-et-dispertire 28466a0
Refactor with suggestions
habere-et-dispertire f4aedf7
Create content.md for modular arithmetic approach
habere-et-dispertire 92267d9
Add modular arithmetic conversion function
habere-et-dispertire 565eaa2
Add modular arithmetic approach to config.json
habere-et-dispertire 66846be
Fix link to Modular Arithmetic approach
habere-et-dispertire c5232dc
Move to modulus folder
habere-et-dispertire 4478566
Move snippet.txt to modulus folder
habere-et-dispertire e321a48
Rename slug from 'modular-arithmetic' to 'modulus'
habere-et-dispertire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
exercises/practice/raindrops/.approaches/modulus/content.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # modular arithmetic | ||
|
|
||
| ```java | ||
| import java.math.BigInteger; | ||
| import static java.math.BigInteger.valueOf; | ||
|
|
||
| class RaindropConverter { | ||
|
|
||
| String convert (int n) { | ||
| return switch ( valueOf(n).modPow( valueOf(12), valueOf(105) ).intValue() ) { | ||
| case 36 -> "Pling"; | ||
| case 85 -> "Plang"; | ||
| case 91 -> "Plong"; | ||
| case 15 -> "PlingPlang"; | ||
| case 21 -> "PlingPlong"; | ||
| case 70 -> "PlangPlong"; | ||
| case 0 -> "PlingPlangPlong"; | ||
| default -> String.valueOf(n); // 1 | ||
| }; | ||
| } | ||
|
|
||
| } | ||
| ``` | ||
|
|
||
| We can generalize raindrops to any factors if they are [co-prime][co-prime]. | ||
| In raindrops the factors 3, 5 and 7 are co-prime (sets of prime numbers are all co-prime) and so we can use [Euler's totient function][euler-totient] to calculate `n¹² mod 105` to give us unique values for the various sounds. | ||
| The math behind how we find the right exponent and modulus is explained in an article on the related problem of [Fizz-Buzz][fizz-buzz]. | ||
|
|
||
| [co-prime]: https://en.wikipedia.org/wiki/Coprime_integers | ||
| [euler-totient]: https://en.wikipedia.org/wiki/Euler's_totient_function | ||
| [fizz-buzz]: https://philcrissman.net/posts/eulers-fizzbuzz/ |
12 changes: 12 additions & 0 deletions
12
exercises/practice/raindrops/.approaches/modulus/snippet.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| String convert (int n) { | ||
| return switch ( valueOf(n).modPow( valueOf(12), valueOf(105) ).intValue() ) { | ||
| case 36 -> "Pling"; | ||
| case 85 -> "Plang"; | ||
| case 91 -> "Plong"; | ||
| case 15 -> "PlingPlang"; | ||
| case 21 -> "PlingPlong"; | ||
| case 70 -> "PlangPlong"; | ||
| case 0 -> "PlingPlangPlong"; | ||
| default -> String.valueOf(n); // 1 | ||
| }; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last part of the URL should match the slug in the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be okay now no (since I changed the slug) ?