Skip to content

Variable length quantity#995

Open
A-O-Emmanuel wants to merge 5 commits into
exercism:mainfrom
A-O-Emmanuel:variable-length-quantity
Open

Variable length quantity#995
A-O-Emmanuel wants to merge 5 commits into
exercism:mainfrom
A-O-Emmanuel:variable-length-quantity

Conversation

@A-O-Emmanuel
Copy link
Copy Markdown
Contributor

This PR updates the PHP track implementation of variable-length-quantity to bring it fully in line with the current canonical data from problem-specifications.

✅ Summary of Changes

  1. Ran configlet sync for the exercise
    Updated exercise metadata using:
    configlet sync -u -e variable-length-quantity --yes --docs --filepaths --metadata --tests include

Ensured Markdown instructions and .meta files reflect the latest canonical content.

Resolved the previously unsynced instructions.md.

  1. Cleaned up strict types comments
    Removed unnecessary // strict_types comments from:

Test file

Example solution

Preserved the directive itself (declare(strict_types=1);) as required for PHP track consistency.

Left the comment intact in the student stub file, per track conventions.

  1. Synced test metadata
    Added missing UUIDs to test DocBlocks.

Updated all #[TestDox] annotations to match canonical descriptions exactly.

Ensured every test case corresponds 1:1 with the canonical JSON.

  1. Updated test method names
    Renamed all test methods to reflect the full canonical description for clarity and consistency.

Ensured naming is deterministic and generator‑friendly.

  1. Added exercise to bin/auto-sync.txt
    Inserted variable-length-quantity alphabetically to keep the file properly ordered.

Ensures future syncs will include this exercise automatically.

  1. Reviewed, adjusted, and ordered test cases
    Verified all test cases match canonical order.

Removed outdated patterns and ensured full alignment with current problem-specifications.

Confirmed no missing or duplicated tests.

  1. Added contributor entry
    Added my GitHub handle to .meta/config.json as a contributor to this exercise.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant