Conversation
There was a problem hiding this comment.
Approach is what I wanted to do but 30 minutes window is too big practically for the use case. We probably want to have a much lower window like 5 minutes for these 3 checks. Should we have one more task with PDP specific checks? We don't want to keep saying we are unhealthy for 30 minutes when there was a transient sync issue.
AJ: 👍
|
@LexLuthr what's a PDP-specific check? |
LexLuthr
left a comment
There was a problem hiding this comment.
Looks good. Can we add alert timing tests?
LexLuthr
left a comment
There was a problem hiding this comment.
We should probably update the docs to new timing changes. It is no longer every 1 hour but every top of the hour.
what is that? |
Fixes #851
Caches the relevant alert results for the ping.
Refreshes every 5 minutes.