fix(auth): expose slot parameters through FirebaseAuthScreen#2328
Open
demolaf wants to merge 4 commits into
Open
fix(auth): expose slot parameters through FirebaseAuthScreen#2328demolaf wants to merge 4 commits into
demolaf wants to merge 4 commits into
Conversation
- AuthMethodPicker - EmailAuth - PhoneAuth - MFA Enrollment & Challenge
…h customizable UI
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive UI customization capabilities to FirebaseAuthScreen by adding slot parameters for email, phone, MFA enrollment, and MFA challenge screens, as well as a custom method picker layout. The demo application has been refactored into separate activities to showcase these new features, including custom method pickers and shape customization. Review feedback suggests optimizing provider categorization using groupBy in the demo, ensuring CircularProgressIndicator uses Modifier.size() to prevent stretching and visual jumps, and reordering function parameters in AuthMethodPicker to place the lambda at the end for better Kotlin idiomaticity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2327 .
FirebaseAuthScreenaccepted customization slots on sub-screens (custom method picker layout, email/phone/MFA content) but never forwarded them, making them unreachable from the high-level API. This adds the missing parameters and wires them through.Also refactors the demo app's Custom Slots & Theming screen into separate activities, adds a SpotlightMethodPicker demo for customMethodPickerLayout, and adds unit tests verifying each slot is forwarded correctly.
Configurable params
Expected behavior
custom-slots-fix.mp4