Skip to content

chore: skill for getting started firebaseui iOS#1344

Open
russellwheatley wants to merge 4 commits into
mainfrom
skill-getting-started
Open

chore: skill for getting started firebaseui iOS#1344
russellwheatley wants to merge 4 commits into
mainfrom
skill-getting-started

Conversation

@russellwheatley

@russellwheatley russellwheatley commented May 18, 2026

Copy link
Copy Markdown
Member

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new skill definition for setting up FirebaseUI in SwiftUI iOS applications, covering workflows, provider setup, and common pitfalls. The review feedback identifies critical improvements regarding the lifecycle management of the AuthService; specifically, it recommends using @State instead of a let property to ensure state persistence across view updates. Additionally, the feedback suggests providing actionable fixes for Xcode preview failures related to Firebase configuration rather than advising users to ignore them.

Comment thread .agents/skills/firebaseui-ios-getting-started/SKILL.md Outdated
Comment thread .agents/skills/firebaseui-ios-getting-started/SKILL.md Outdated
Comment thread .agents/skills/firebaseui-ios-getting-started/SKILL.md
Comment thread .agents/skills/firebaseui-ios-getting-started/SKILL.md Outdated
Comment thread .agents/skills/firebaseui-ios-getting-started/SKILL.md Outdated
@github-actions

Copy link
Copy Markdown

Hello, this PR has been open for more than 28 days with no activity.

If you think this is a mistake, please comment to keep this open. Thanks for contributing!

This PR will be closed in 15 days if no further activity occurs.

@github-actions github-actions Bot added the stale label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant