feat: add FirebaseStorageUISwift product for Swift SPM clients, fix(FirebaseStorageUI): prevent crash with .progressiveLoad on Firebase Storage 9+#1351
Merged
Conversation
f5778a6 to
0272a43
Compare
7f14c66 to
81e5e29
Compare
81e5e29 to
cc85959
Compare
SelaseKay
approved these changes
Jun 11, 2026
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1146
Closes #1114
Fix 1:
Swift SPM clients currently can't call
sd_setImage(with:)passing aStorageReference— the ObjC headers use@classforward declarations (required to fix the Clang scan-phase failure in #1350), which leavesStorageReferenceopaque to the Swift importer.This PR adds
FirebaseStorageUISwift, a new Swift-only SPM library product that bridges this gap by providing properly-typed Swift extensions onUIImageView.Also migrates
FirebaseUI-demo-swiftfrom CocoaPods to SPM and updatesStorageViewControllerto demonstrate the new API.Fix 2
FIRStorageDownloadTask.fetcherwas an internal property removed in Firebase Storage 9.0.0. Accessing it via the progress observer caused a crash when.progressiveLoadwas passed as an option.Guard with
respondsToSelector:so the progressive decode path is skipped on Firebase 9+. Images still load to completion — only the in-flight progressive rendering is lost, since Firebase no longer exposes partial download data publicly.New product
Add
FirebaseStorageUISwiftto your SPM dependencies andimport FirebaseStorageUISwift. This re-exports bothFirebaseStorageUIandFirebaseStorage, so no additional imports are needed.API Changes