docs: clarify how to run tests for both packages#287
Open
demolaf wants to merge 2 commits into
Open
Conversation
…for google_cloud_firestore
Coverage Report✅ Coverage 75.19% meets 40% threshold Total Coverage: 75.19% Package Breakdown
Minimum threshold: 40% |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test documentation in CONTRIBUTING.md to explain the new tag-based presets defined in dart_test.yaml and simplifies the Firestore emulator command in scripts/firestore-coverage.sh. Feedback highlights a bug in scripts/firestore-coverage.sh where setting GOOGLE_APPLICATION_CREDENTIALS causes emulator and production tests to be silently skipped due to empty tags. Additionally, the relative paths to the convenience scripts in CONTRIBUTING.md need to be corrected to ../../scripts/ since the instructions are executed from package subdirectories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #268
Adds a
firebase.jsontopackages/google_cloud_firestore/so the package is self-contained, and rewrites the Running Tests section inCONTRIBUTING.mdwith accurate instructions covering both packages and all test presets.