[listen] Creates listen package by chunhtai · Pull Request #24 · flutter/core-packages

chunhtai · 2026-06-11T22:03:52Z

code are striped from the flutter/flutter with history intact.

The change is in last commit

Add ci harness
rewire memory leak and error handling harness
add examples

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

google-cla · 2026-06-11T22:06:49Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This introduces the key parts of a paginated data table, not including the built-in pagination features. * Provide more data for the data table demo, so there's data to page. * Introduce a ChangeNotifier class which abstracts out addListener/removeListener/notifyListeners. We might be able to use this to simplify existing classes as well, though this patch doesn't do that. * Introduce DataTableSource, a delegate for getting data for data tables. This will also be used by ScrollingDataTable in due course. * Introduce PaginatedDataTable, a widget that wraps DataTable and only shows N rows at a time, fed by a DataTableSource.

This patch improves some subtle behaviors about the change notifier.

…889) Having this base class lets classes like CustomPainter and DataTableSource be more agnostic as to what's generating the repaints.

Sometimes you have several listenables, but you want to hand them to an API (e.g. CustomPainter) that only expects one.

This lets you use `Listenable.merge` without having to sanitize your incoming list of change notifiers, in case your semantics are that they are optional.

* MultiTapGestureRecognizer previously would assert if there was no competition. * GestureArenaTeam would always select the first recongizer as the winner even if a later recognizer actually accepted the pointer sequence. * debugPrintStack would fail a type check if maxFrames was non-null. * FractionalOffset.lerp would throw a null-pointer exception if its second argument was null. Also, add a number of tests for previously untested lines of code.

It took me a while to figure out what was going on (I was removing a listener after disposal). These asserts helped.

This patch aligns the iteration patterns used by animations and ChangeNotifier. They now both respect re-entrant removal of listeners and coalesce duplication registrations. (Also, ChangeNotifier notification is no longer N^2). Fixes #7533

This patch aligns the iteration patterns used by animations and ChangeNotifier. They now both respect re-entrant removal of listeners and coalesce duplication registrations. (Also, ChangeNotifier notification is no longer N^2). This patch introduces ObserverList to avoid the performance regression that the previous version of this patch caused. Fixes #7533

Fixes for: flutter/flutter#7570 flutter/flutter#7231 flutter/flutter#2841 and others

It's common to have a ChangeNotifier that wraps a single value. This class makes that easy by providing a generic implementation.

* Change foundation references to meta * Remove specified shows

After this patch, there are three major text input widgets: * EditableText. This widget is a low-level editing control that interacts with the IME and displays a blinking cursor. * TextField. This widget is a Material Design text field, with all the bells and whistles. It is highly configurable and can be reduced down to a fairly simple control by setting its `decoration` property to null. * TextFormField. This widget is a FormField that wraps a TextField. This patch also replaces the InputValue data model for these widgets with a Listenable TextEditingController, which is much more flexible. Fixes #7031

…e method. (#10871) * Change all instances of '$runtimeType#$hashCode' to use the describeIdentity method. The describeIdentity method generates a shorter description with a consistent length consisting of the runtime type and the a 5 hex character long truncated version of the hash code.

…idAndType method. (#10871)" (#10880) This reverts commit d6afe09.

…eIdentity (#10888) * Revert "Revert "Change all ocurrences of '$runtimeType#$hashCode' to use the idAndType method. (#10871)" (#10880)" This reverts commit 7ccc66f.

Add Diagnosticable base class and documentation

I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.

* Fix the confusing-zero case with NestedScrollView. * Update mock_canvas.dart * Update tabs_demo.dart * more tweaks

I found that some ValueListeners want to know when they should start doing work (e.g. if the value comes from polling a network resource).

This auto-formats all *.dart files in the repository outside of the `engine` subdirectory and enforces that these files stay formatted with a presubmit check. **Reviewers:** Please carefully review all the commits except for the one titled "formatted". The "formatted" commit was auto-generated by running `dev/tools/format.sh -a -f`. The other commits were hand-crafted to prepare the repo for the formatting change. I recommend reviewing the commits one-by-one via the "Commits" tab and avoiding Github's "Files changed" tab as it will likely slow down your browser because of the size of this PR. --------- Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>

@goderbauer

Fixes flutter/flutter#137435 Tests are not needed because it is refactoring. Requested [exempt](https://discord.com/channels/608014603317936148/608018585025118217/1343801945982505001). @goderbauer , if looks good, can you merge it please, to avoid conflicts, as there are many files here?

Mostly related to error tracking.

Bumps the Dart version to 3.8 across the repo (excluding engine/src/flutter/third_party) and applies formatting updates from Dart 3.8. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@loic-sharma

WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of flutter/flutter#178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

fixes #142418 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

doc should start with one sentence ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

gemini-code-assist

Code Review

This pull request introduces the listen package, a lightweight synchronous listener registry for pure Dart applications, containing implementations of Listenable, ChangeNotifier, and ValueNotifier along with examples and tests. The review feedback identifies an invalid dependency version constraint for meta in pubspec.yaml, several references to Flutter-specific classes in the documentation that should be updated for a pure Dart package, and a hardcoded library name 'foundation' that should be changed to 'listen'.

stuartmorgan-g

I only looked at the changes to fit into the repo structure; someone more familiar with the intended usage and the migration plan for clients should definitely review the package API itself.

stuartmorgan-g · 2026-06-29T14:51:07Z

+description: A lightweight synchronous listener registry for pure Dart applications.
+repository: https://github.com/flutter/core-packages/tree/main/packages/listen
+issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+listen%22
+version: 0.1.0


It looks like someone published a placeholder package as 1.0.0-beta, which is going to make publishing a 0.x release confusing.

stuartmorgan-g · 2026-06-29T14:53:47Z

+
+/// Demonstrates [ValueNotifier] usage for README.
+// #docregion ValueNotifier
+void valueNotifierExample() {


Is there a reason this is duplicated almost exactly here from main.dart, instead of the README snippet just pulling from main.dart?

That will require adding the #docregion identifier on the main.dart, which I think may be confusing for people looking at the example. so I intentionally group all excerpt related code in one file even if I can probably grab the code from some other example. Let me know reducing duplication here is more preferred.

Traditionally we haven't worried about having it in main.dart, and only use readme_excerpts.dart when there were things we wanted to show in the README that weren't in the example.

It's not a rule though, so if you are concerned about the comments in the example this is fine.

I will keep this as-is

loic-sharma · 2026-06-29T17:19:30Z

+  }
+}
+
+/// Demonstrates [ChangeNotifier] usage for README.


Nit: can we remove this line? Or could we split this into two excerpts so that we can skip this line?

loic-sharma · 2026-06-29T17:34:16Z

+
+# listen
+
+A lightweight synchronous listener registry for pure Dart applications.


This line feels a little abstract and might be difficult to understand if you have no context. What do you think of this instead?

Suggested change

A lightweight synchronous listener registry for pure Dart applications.

A package to notify state changes to interested listeners.

Hixie and others added 29 commits June 25, 2026 18:39

Improve change notifier (#4747)

ddb441d

This patch improves some subtle behaviors about the change notifier.

Extract a Listenable base class from Animation and ChangeNotifier (#5…

70d66bc

…889) Having this base class lets classes like CustomPainter and DataTableSource be more agnostic as to what's generating the repaints.

Listenable.merge (#7256)

b928281

Sometimes you have several listenables, but you want to hand them to an API (e.g. CustomPainter) that only expects one.

Allow nulls in Listenable.merge (#7355)

23dda28

This lets you use `Listenable.merge` without having to sanitize your incoming list of change notifiers, in case your semantics are that they are optional.

Add more asserts and docs to ChangeNotifier. (#7513)

ed19257

It took me a while to figure out what was going on (I was removing a listener after disposal). These asserts helped.

Revert "Strengthen animation listener iteration patterns" (#7552)

9be184a

Various documentation fixes. (#7726)

f758e93

Fixes for: flutter/flutter#7570 flutter/flutter#7231 flutter/flutter#2841 and others

Add ValueNotifier (#8463)

4adb1f3

It's common to have a ChangeNotifier that wraps a single value. This class makes that easy by providing a generic implementation.

Animation Demo performance tweaks (#8586)

3a4717c

Remove imports of meta (#9081)

cea97ac

Change foundation references in foundation to meta (#9107)

aa8474e

* Change foundation references to meta * Remove specified shows

Better toStrings for Listenable subclasses (#9244)

5b6a595

Simplify change notifier toString and handle nulls (#9368)

75fd887

More docs. (#10214)

2521f2e

More documentation (#10589)

1d927b5

Revert "Change all ocurrences of '$runtimeType#$hashCode' to use the …

f3fe60a

…idAndType method. (#10871)" (#10880) This reverts commit d6afe09.

Change all occurrences of '$runtimeType#$hashCode' to use the describ…

0370c2c

…eIdentity (#10888) * Revert "Revert "Change all ocurrences of '$runtimeType#$hashCode' to use the idAndType method. (#10871)" (#10880)" This reverts commit 7ccc66f.

Add Diagnosticable base class and add documentation. (#11458)

bd4b999

Add Diagnosticable base class and documentation

use bool in assert (#12170)

02e2d32

Fix the confusing-zero case with NestedScrollView. (#14133)

8aa7aca

* Fix the confusing-zero case with NestedScrollView. * Update mock_canvas.dart * Update tabs_demo.dart * more tweaks

some whitespace cleanup (#14443)

f9d12c6

Add a hasListeners to ChangeNotifier (#14946)

c8ae2f8

I found that some ValueListeners want to know when they should start doing work (e.g. if the value comes from polling a network resource).

goderbauer and others added 7 commits June 25, 2026 18:39

Flutter test cleanup (#170891)

55ed68c

Mostly related to error tracking.

chunhtai force-pushed the create-listen-package branch 3 times, most recently from 44b2283 to 2118fe9 Compare June 28, 2026 09:07

chunhtai changed the title ~~[WIP] Creates listen package~~ [listen] Creates listen package Jun 28, 2026

chunhtai requested review from justinmc and stuartmorgan-g June 28, 2026 09:08

chunhtai marked this pull request as ready for review June 28, 2026 09:08

gemini-code-assist Bot reviewed Jun 28, 2026

View reviewed changes

Comment thread packages/listen/pubspec.yaml Outdated

Comment thread packages/listen/lib/src/listen.dart Outdated

Comment thread packages/listen/lib/src/listen.dart Outdated

Comment thread packages/listen/lib/src/listen.dart Outdated

Comment thread packages/listen/lib/src/listen.dart Outdated

Adds listenable package

a2354b4

chunhtai force-pushed the create-listen-package branch from 2118fe9 to a2354b4 Compare June 28, 2026 09:52

kevmoo mentioned this pull request Jun 29, 2026

Move useful Flutter types out of Flutter flutter/flutter#149466

Open

stuartmorgan-g reviewed Jun 29, 2026

View reviewed changes

loic-sharma reviewed Jun 29, 2026

View reviewed changes

Comment thread packages/listen/lib/listen.dart Outdated

loic-sharma reviewed Jun 29, 2026

View reviewed changes

Comment thread packages/listen/example/test/example_test.dart

loic-sharma reviewed Jun 29, 2026

View reviewed changes

Comment thread packages/listen/lib/src/listen.dart

Piinks added the triage-framework Should be looked at in framework triage label Jun 29, 2026

github-actions Bot removed the triage-framework Should be looked at in framework triage label Jul 1, 2026

addressing comments

da26a37

chunhtai force-pushed the create-listen-package branch from ecf0f23 to da26a37 Compare July 1, 2026 02:02

chunhtai requested review from loic-sharma and stuartmorgan-g July 1, 2026 02:07


		# listen

		A lightweight synchronous listener registry for pure Dart applications.

	A lightweight synchronous listener registry for pure Dart applications.
	A package to notify state changes to interested listeners.

Uh oh!

Conversation

chunhtai commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

google-cla Bot commented Jun 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loic-sharma Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

chunhtai commented Jun 11, 2026 •

edited

Loading

loic-sharma Jun 29, 2026 •

edited

Loading