Skip to content

Bump react-app-rewired from 2.1.6 to 2.1.9#396

Open
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/npm_and_yarn/react-app-rewired-2.1.9
Open

Bump react-app-rewired from 2.1.6 to 2.1.9#396
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/npm_and_yarn/react-app-rewired-2.1.9

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Dec 23, 2021

Copy link
Copy Markdown
Contributor

Bumps react-app-rewired from 2.1.6 to 2.1.9.

Release notes

Sourced from react-app-rewired's releases.

2.1.9

timarney/react-app-rewired#589

2.1.8

fix: support false values in jest config override timarney/react-app-rewired#498

2.1.7

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [react-app-rewired](https://github.com/timarney/react-app-rewired) from 2.1.6 to 2.1.9.
- [Release notes](https://github.com/timarney/react-app-rewired/releases)
- [Commits](timarney/react-app-rewired@2.1.6...v2.1.9)

---
updated-dependencies:
- dependency-name: react-app-rewired
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 23, 2021
@codecov-commenter

codecov-commenter commented Dec 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #396 (42ffeb8) into master (fde5058) will increase coverage by 0.34%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   50.35%   50.70%   +0.34%     
==========================================
  Files          19       19              
  Lines         141      142       +1     
  Branches       28       28              
==========================================
+ Hits           71       72       +1     
  Misses         60       60              
  Partials       10       10              
Impacted Files Coverage Δ
src/pages/UserSettings.js 33.33% <0.00%> (ø)
src/components/skeleton/content/Content.js 85.71% <80.00%> (ø)
src/App.js 100.00% <100.00%> (ø)
src/components/skeleton/footer/Footer.js 100.00% <100.00%> (ø)
src/components/skeleton/header/Header.js 100.00% <100.00%> (ø)
src/components/skeleton/layout/Layout.js 100.00% <100.00%> (ø)
src/components/skeleton/sider/Sider.js 100.00% <100.00%> (ø)
src/pages/Home.js 100.00% <100.00%> (ø)
src/routes/withHelmet.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde5058...42ffeb8. Read the comment docs.

Comment thread src/pages/Home.js

export default () => (
<>
export default function () {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function default has 59 lines of code (exceeds 25 allowed). Consider refactoring.

shape="square"
className="avatar"
icon={<UserOutlined />}
const Header = function ({ isSiderCollapsed, onToggleSider }) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected unnamed function.

Comment thread src/App.js
<Switch>{renderRoutes(getRoutes({ isLoggedUser: true }))}</Switch>
</BrowserRouter>
);
const App = function () {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete ·

<div style={{ padding: 16 }}>{children}</div>
</AntContent>
);
const Content = function ({ children, matchedRoutes }) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected unnamed function.

const Footer = ({ footer }) => (
<AntFooter style={{ textAlign: 'center' }}>{footer}</AntFooter>
);
const Footer = function ({ footer }) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected unnamed function.

@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 42ffeb8 and detected 18 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Clarity 5
Style 12

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.5% (0.0% change).

View more on Code Climate.

@dependabot @github

dependabot Bot commented on behalf of github Dec 30, 2021

Copy link
Copy Markdown
Contributor Author

A newer version of react-app-rewired exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants