Load plugin during init face to prevent race conditions#27
Open
dryajov wants to merge 1 commit into
Open
Conversation
(cherry picked from commit 8cc007e)
Author
|
@jeremyzahner Any chance of taking a look at this? |
Open
Contributor
|
@dryajov Hey there! Sorry for the waiting time. I'll have a look at this asap. |
luisfranco
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an NPE due to a null $wp_rewrite registering a page type. I think it makes sense to delay plugin bootstrap/registration to the init face when WP is initialized.