fix(init): simplify LoggingUI output for non-TTY consumers#941
Draft
MathurAditya724 wants to merge 1 commit intomainfrom
Draft
fix(init): simplify LoggingUI output for non-TTY consumers#941MathurAditya724 wants to merge 1 commit intomainfrom
MathurAditya724 wants to merge 1 commit intomainfrom
Conversation
Skip the ASCII banner entirely in LoggingUI (non-TTY/CI) and drop the `... ` prefix from spinner status lines. This reduces noise for programmatic consumers (agents, scripts, piped output) without affecting the interactive InkUI path. Fixes #940
Contributor
|
Contributor
Codecov Results 📊✅ 6836 passed | Total: 6836 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 13932 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 77.03% 77.02% -0.01%
==========================================
Files 317 317 —
Lines 60609 60615 +6
Branches 0 0 —
==========================================
+ Hits 46684 46683 -1
- Misses 13925 13932 +7
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoggingUI is used in non-TTY / CI contexts (--yes, piped output, npm/Node distribution). Two changes to reduce noise for programmatic consumers:
...prefix from spinner status lines —Checking prerequisites...reads cleaner than... Checking prerequisites...in structured logs.The interactive InkUI path is unaffected.
Testing
bun test test/lib/init/ui/logging-ui.test.ts— all 25 tests pass.Fixes #940