fix(eap): Port set_segment_attributes to V2 span pipeline#6164
Closed
loewenheim wants to merge 3 commits into
Closed
fix(eap): Port set_segment_attributes to V2 span pipeline#6164loewenheim wants to merge 3 commits into
loewenheim wants to merge 3 commits into
Conversation
Dav1dde
approved these changes
Jul 2, 2026
Member
|
Wondering if we need that, for now we only need to deal with webvital legacy spans. |
Contributor
Author
|
We probably don't actually need this: the legacy standalone pipeline is really only used for web vital spans, so the added normalizations would probably never actually happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends #6042 by porting the entire
set_segment_attributesfunction (which contains the logic implemented in that PR) to the V2 standalone span pipeline. The normalization function and the settings flag are renamed accordingly.I've also added a test that exercises every possible way through this function (for non-web-vital spans—those are already covered by existing tests).
ref: INGEST-943