ref(data-collection): Rework DataCollection as a TypedDict, drop accessors#6702
Draft
ericapisani wants to merge 1 commit into
Draft
ref(data-collection): Rework DataCollection as a TypedDict, drop accessors#6702ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
…ssors Replace the class-based DataCollection/KeyValueCollectionBehavior/ GenAICollection/HttpHeadersCollection API with plain TypedDicts (DataCollection, DataCollectionUserOptions, and per-category *CollectionBehaviour/*UserOptions types) defined in _types.py. Collection mode strings move from camelCase (denyList/allowList) to snake_case (deny_list/allow_list) to match Python convention, since this is a Python-only deviation from the spec that is never serialized to Sentry. Drop the should_collect_user_info/should_collect_gen_ai_inputs/ should_collect_gen_ai_outputs accessor methods and their module-level shortcuts in favor of reading data_collection fields directly, and drop the public sentry_sdk.DataCollection/GenAICollection/ HttpHeadersCollection/KeyValueCollectionBehavior exports. Revert the Unreleased CHANGELOG entry and README example for the prior class-based API.
Contributor
Codecov Results 📊✅ 90745 passed | ⏭️ 6240 skipped | Total: 96985 | Pass Rate: 93.57% | Execution Time: 324m 55s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 90.67%. Project has 2409 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.74% 89.94% +0.2%
==========================================
Files 192 193 +1
Lines 23819 23952 +133
Branches 8222 8304 +82
==========================================
+ Hits 21375 21543 +168
- Misses 2444 2409 -35
- Partials 1348 1352 +4Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the class-based DataCollection/KeyValueCollectionBehavior/GenAICollection/HttpHeadersCollection API with plain TypedDicts