Update publish.yml to add id-token permission#17
Open
gracepark wants to merge 1 commit intogithub:mainfrom
Open
Update publish.yml to add id-token permission#17gracepark wants to merge 1 commit intogithub:mainfrom
gracepark wants to merge 1 commit intogithub:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the npm publish GitHub Actions workflow to support npm OIDC-based provenance signing by granting id-token: write and switching the publish command to use --provenance.
Changes:
- Added
permissions: id-token: writeto enable GitHub OIDC token minting for the workflow. - Updated the npm publish step to run
npm publish --provenance(and removed the token-basednpm whoami/NODE_AUTH_TOKENusage).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Enables OIDC (id-token) and uses npm publish --provenance for the npm release workflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| - run: npm whoami; npm --ignore-scripts publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.npm_token}} | ||
| - run: npm --ignore-scripts publish --provenance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
Updated publish workflow to include permissions and modify npm publish commands as we've migrated to OIDC.